Sorry to break it to you, but the patch still doesn't have correct
mime-type. From your mail:
Content-Disposition: attachment;
filename=hacking.html.diff
Content-Type: application/octet-stream;
name=hacking.html.diff;
x-unix-mode=0644
(I'm not trying to go an be all pedantic about this. I would actually
like to review the patch, but the mime-type confusion presents a very
real barrier to that. My reader won't display something with a binary
mime-type inline, meaning that reviewing the patch is more hassle than
it's worth.)
-Hyrum
On Apr 14, 2009, at 11:05 PM, Gavin 'Beau' Baumanis wrote:
> Of course...
>
> How nice of the PM to submit a patch inappropriately!
> Would the excuse it was meant to be .patch (not -patch) work for
> you?? :D
>
> <hacking.html.diff>
>
>
>
> On 15/04/2009, at 1:27 PM, Hyrum K. Wright wrote:
>
>> Can we have the patch attached using one of the suggested mime-types
>> [1]? :P
>>
>> [1] text/x-diff, text/x-patch, or text/plain
>>
>> On Apr 14, 2009, at 9:54 PM, Gavin Baumanis wrote:
>>
>>> As discussed at;
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>>>
>>> [[[
>>> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>>>
>>> * www/hacking.html
>>>
>>> Patch by: Gavin Baumanis <gavinb_at_thespidernet.com>
>>> Found by: gstein
>>> ]]]
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
>>> <hacking.html-patch>As discussed at;
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496987
>>>
>>> [[[
>>> Update HACKING: Mutual respect / Evaluate the code, not the coder.
>>>
>>> * www/hacking.html
>>>
>>> Patch by: Gavin Baumanis <gavinb_at_thespidernet.com>
>>> Found by: gstein
>>> ]]]
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720169
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1720557
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1721171
Received on 2009-04-15 06:19:15 CEST