On Sat, Apr 11, 2009 at 12:56 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Sat, Apr 11, 2009 at 12:18:44PM -0400, Mark Phippard wrote:
>> On Fri, Apr 10, 2009 at 6:48 PM, Neels Janosch Hofmeyr <neels_at_elego.de> wrote:
>> > Neels Janosch Hofmeyr wrote:
>> >> Right, if no-one speaks up this time, I'll make two new issues.
>> > Buddy system!
>> >
>> > Does anyone agree that these two are good to be issues?
>> >
>> > #1 externals with a fixed revision aren't locked for commit as long as
>> > that fixed revision coincides with HEAD.
>> >
>> > #2 when a file-external with a fixed revision is modified, the next
>> > update causes a conflict with the (unrelated) HEAD revision.
>> >
>> > I am attaching a shell script that makes both of them happen, for both file-
>> > and directory externals.
>>
>> I agree these would be good changes. I suspect they will be difficult
>> to implement. AFAIK, svn does not always even know you are working in
>> an external. Especially when we are talking about folders. For
>> example, if you run commands like svn st from your project root, then
>> it knows that those folders and items are externals. But if you run
>> the command from a folder down within the external, it no longer knows
>> this. The only way the command line will commit externals is to do
>> this. So you'd have to ask the command line code to always walk the
>> tree to the root of the WC so that it could then discover if an item
>> is an external. That seems like a risky change for a small benefit.
>>
>> Ideally, and perhaps the new WC will allow this?, the WC would just
>> know that these items are externals and could handle them differently.
>
> Since externals probably won't be easy to fix in 1.6.x, I'd say it
> makes sense to make these fixes in wc-ng, hopefully released in 1.7.x.
>
> And I'd rather see yet another dev get accustomed to wc-ng code
> instead of trying to fix things in the ever-so-broken old libsvn_wc.
+1. These "fixes" would be pretty borderline candidates for backport anyway.
I think it'd be great to see someone give externals some love rather
than just talk about how we need something new to replace them and
then never do it.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1652166
Received on 2009-04-11 19:06:59 CEST