Re: svn_stream_copy3() in svn_io.h

Greg Stein wrote:

> Right. I added to the TODO for specifically that reason: the streams
> may not get closed if an error occurs. In some scenarios, we want to
> ensure that svn_stream_close() is *always* called on certain streams.
> Their logic needs/wants to rely on the fact that the streams will
> always be closed after calling svn_stream_copy3().
>
> Edmund: this should be a nice little bite-sized task to tweak that
> function to ensure they're always closed.
>

I have been thinking about this task and if I may proverbially
pick your brain (or anyone else's for that matter), even if
an error arises, say cancel_func(cancel_baton)) chokes and
errors, then SVN_ERR will return the error back to
svn_stream_copy3 which then returns the error to the calling
program, right?

So just as long as I still capture the svn_error_t and still
have the function flow get to the final return, all is well?

Have I got the task correctly, for lack of a better word,
diagnosed?

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1587608
Received on 2009-04-08 03:31:42 CEST