RE: [PATCH] Fix issue #2586

> -----Original Message-----
> From: Senthil Kumaran S [mailto:senthil_at_collab.net]
> Sent: donderdag 2 april 2009 14:52
> To: dev_at_subversion.tigris.org
> Subject: [PATCH] Fix issue #2586
>
> Hi,
>
> I am attaching a patch which fixes issue #2586. If there is no comments on
> this, I shall commit it tomorrow.
>
> [[[
> Fix issue #2586.
>
> * subversion/libsvn_client/add.c
> (mkdir_urls): Early exit when there is a mix of URLs and local paths.
> ]]]

I think you could use svn_path_is_url() ?

If you use an iterpool you should create it outside the loop, clear it
before use and destroy it after the loop. (Your loop creates a new iterpool
for every iteration and never destroys the iterpool).

svn_path_is_url() doesn't need a pool...
(And I don't know what hostname apr_uri_parse provides for
file:///G:/repos/dir/file.. Might be "" or NULL)

Thanks,

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1518802
Received on 2009-04-02 15:09:54 CEST