[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36894 - in trunk/subversion: libsvn_client libsvn_repos mod_dav_svn svn

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 31 Mar 2009 17:11:43 +0200

On Tue, Mar 31, 2009 at 17:06, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
>...
>> +++ trunk/subversion/mod_dav_svn/repos.c      Tue Mar 31 07:51:57 2009
>...
>> @@ -2258,10 +2259,10 @@ get_parent_path(const char *path, apr_po
>>
>>    if (len > 0)
>>      {
>> -      /* Remove any trailing slash; else svn_path_split() asserts. */
>> +      /* Remove any trailing slash; else svn_dirent_split() asserts. */
>>        if (tmp[len-1] == '/')
>>          tmp[len-1] = '\0';
>> -      svn_path_split(tmp, &parentpath, &base_name, pool);
>> +      svn_dirent_split(tmp, &parentpath, &base_name, pool);
>>
>>        return parentpath;
>>      }
>
> This should probably be svn_uri_split() and if it isn't the '/' can't be
> removed because a final '/' can be valid in a dirent. (E.g. "C:/"). In that
> case one of the dirent normalization methods should be used.

Ah... svn_uri_split() is correct. mod_dav_svn doesn't really deal with dirents.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1496627
Received on 2009-03-31 17:11:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.