Re: [PATCH] change-svn-wc-format (minor change)

2009-03-31 06:22 Edmund Wong <edmund_at_belfordhk.com> napisał(a):
> Minor change to line #93.  According to Python rules,
> the following is 'wrong' (for v2.6):
>
>   except UnrecognizedWCFormatException, e:
>
> It should be:
>
>   except (UnrecognizedWCFormatException, e):

No. The code was correct. It catches UnrecognizedWCFormatException and
assigns it to variable 'e'.

> Please note that this was 'accidentally' pointed out by
> ibarrien_at_adobe.com.  I looked at the v2.6 rules and
> 'lo and behold, it's wrong to have the first line.
> (Of course, the interpreter didn't complain when
> I ran it, but rules are rules.) Mind you, he was referring
> to Python 3.01, in which case the statement should
> be:
>
>   except (UnrecognziedWCFormatException as e):

In Python 3 this line would have to be:

except UnrecognizedWCFormatException as e:

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1494800
Received on 2009-03-31 13:12:10 CEST