Re: [PATCH] change-svn-wc-format.py

Edmund Wong wrote:
>
> Btw, someone on the users list is asking for a Python 3.0
> version of this script because it's err'ing on line 92,
> which is :
>
> except UnrecognizedWCFormatException, e:
>
> It's scary how coincidental this is considering I only
> just finished patching this script.
>

I was reading the changes at python.org and came across
this tidbit:

One error that Python programmers occasionally make is writing the
following code:

try:
     ...
except TypeError, ValueError: # Wrong!
     ...

The author is probably trying to catch both TypeError and ValueError
exceptions, but this code actually does something different: it will
catch TypeError and bind the resulting exception object to the local
name "ValueError". The ValueError exception will not be caught at all.
The correct code specifies a tuple of exceptions:

try:
     ...
except (TypeError, ValueError):

Does this mean I'll need to go through the latest revision of
change-svn-wc-format.py and modify these exception catching
lines?

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1490766
Received on 2009-03-31 12:57:52 CEST