[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36851 - trunk/subversion/libsvn_fs_base

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 30 Mar 2009 18:35:04 +0200

On Mon, Mar 30, 2009 at 16:41, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
>...
> +++ trunk/subversion/libsvn_fs_base/fs.c        Mon Mar 30 07:41:13 2009        (r36851)
> @@ -819,12 +819,18 @@ base_upgrade(svn_fs_t *fs, const char *p
>  {
>   const char *version_file_path;
>   int old_format_number;
> +  svn_error_t *err;
>
>   version_file_path = svn_path_join(path, FORMAT_FILE, pool);
>
>   /* Read the old number so we've got it on hand later on. */
> -  SVN_ERR(svn_io_read_version_file(&old_format_number, version_file_path,
> -                                   pool));
> +  err = svn_io_read_version_file(&old_format_number, version_file_path, pool);
> +  if (APR_STATUS_IS_ENOENT(err->apr_err))

Hmm? And won't this fail miserably when err == NULL ?

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1483686
Received on 2009-03-30 18:35:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.