Re: questionable code?

Matthew Woehlke wrote:
> In find_unmerged_mergeinfo (subversion/libsvn_client/merge.c circa line
> 7490), the line near the bottom of the function:
> if (SVN_IS_VALID_REVNUM(youngest_merged_rev))
>
> ...causes a compile error on c89 compilers. It looks like this line
> should actually be:
> if (SVN_IS_VALID_REVNUM(*youngest_merged_rev))
>
> (Noticed in 1.5.6 and 1.6.0.)

Yes, that does look like a bug. Fixed in r36783.

Paul, should this be merged into 1.5.x and 1.6.x?

Regards,
Blair

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1421174
Received on 2009-03-25 23:45:18 CET