[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Why bother about r->main in webdav write through proxy code?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 18 Mar 2009 11:55:43 -0400

Kamesh Jayachandran wrote:
> Hi All,
>
> I was going through the webdav write through proxy filter code.
> I could see check for 'r->main' in it.
>
> I tested the following,
> 1. slave writing to different master host.
> 2. slave writing to same master host instance but on a different uri.
>
> In both tests I could 'r->main' is always null.
>
> I am not sure why we should bother about sub request inside by checking
> for r->main?

We only use subrequests ourselves when invoking the authz callback, and we
always invoke that using a GET request (which isn't proxied through). But
by keeping the checks for r->main present, we avoid the unnecessary proxy
logic altogether for those subrequests, don't we?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1349179

Received on 2009-03-18 16:56:58 CET

This is an archived mail posted to the Subversion Dev mailing list.