[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36625 - in branches/1.6.x: . subversion/po subversion/svn

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 17 Mar 2009 16:28:41 +0100

On Tue, Mar 17, 2009 at 15:57, Jens Seidel <jensseidel_at_users.sf.net> wrote:
> On Tue, Mar 17, 2009 at 03:56:01PM +0100, Greg Stein wrote:
>> You touched a file in svn/main.c on the release branch. That is not
>> allowed. Your commit area is limited to subversion/po/ only.
>> *ESPECIALLY* when it comes to the *RELEASE BRANCH*.
>>
>> This is Bad.
>
> I'm sorry, but why was the help message not updated before? I reported it

It was updated on trunk, and there is an outstanding VOTE to update it
on the branch.

> early enough and noticed that it wasn't backported once I updated the German
> translation recently (which happened also very late).
>
> All in all it's a minor change but I consider help messages important and it
> should not lie.

That is not your call to make. There is a VOTE for it. That is how
things work. None of the committers (full or partial) are free to
simply make changes in the release branch because they consider
something "important".

> I agree it's late in the release cycle, sorry for it.

And that makes it even more important to following the voting
guidelines, and to defer all branch merges to the Release Manager.

It is a minor change, but not *that* minor. How do I know that the new
help output is correct? I can't just eyeball it. I have to set up a
tree conflict somehow and then run "svn status" to see what the
*actual* output is, and then compare it against what is being put into
the help text. Thus, it is not an "obvious fix".

As it stands, it was scheduled to be fixed in 1.6.1. Not in 1.6.0.

-g

>> On Tue, Mar 17, 2009 at 15:22, Jens Seidel <jensseidel_at_users.sf.net> wrote:
>> >  "    svn status\n"
>> >  "     M      wc/bar.c\n"
>> >  "    !     C wc/qaz.c\n"
>> > -"          >   incoming edit, local missing\n"
>> > +"          >   local missing, incoming edit upon update\n"
>> >  "    D       wc/qax.c\n"
>
> Jens
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1341862
Received on 2009-03-17 16:28:59 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.