[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36529 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 14 Mar 2009 13:42:57 +0100

On Fri, Mar 13, 2009 at 18:50, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_wc/wc_db.c  Fri Mar 13 10:50:20 2009        (r36529)
>...
> @@ -2557,9 +2564,35 @@ svn_wc__db_read_pristine_props(apr_hash_
>                                apr_pool_t *result_pool,
>                                apr_pool_t *scratch_pool)
>  {
> +  svn_wc__db_pdh_t *pdh;
> +  const char *local_relpath;
> +  svn_sqlite__stmt_t *stmt;
> +  svn_boolean_t have_row;
> +
>   SVN_ERR_ASSERT(svn_dirent_is_absolute(local_abspath));
>
> -  NOT_IMPLEMENTED();
> +  SVN_ERR(parse_local_abspath(&pdh, &local_relpath, db, local_abspath,
> +                              svn_sqlite__mode_readonly,
> +                              scratch_pool, scratch_pool));
> +
> +  SVN_ERR(svn_sqlite__get_statement(&stmt, pdh->sdb, STMT_SELECT_ALL_PROPS));

Wrong statement.

> +  SVN_ERR(svn_sqlite__bindf(stmt, "is", pdh->wc_id, local_relpath));
> +  SVN_ERR(svn_sqlite__step(&have_row, stmt));
> +  if (!have_row)
> +    return svn_error_createf(SVN_ERR_WC_PATH_NOT_FOUND, NULL,
> +                             _("The node '%s' was not found."),
> +                             svn_dirent_local_style(local_abspath,
> +                                                    scratch_pool));
> +
> +  /* Try ACTUAL, then WORKING and finally BASE. */
> +  if (!svn_sqlite__column_is_null(stmt, 0))

Comment is wrong.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1321746
Received on 2009-03-14 13:43:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.