Re: [PATCH/RFC] Add separate error code for RA Forbidden

On Wed, Mar 4, 2009 at 7:41 PM, Jelmer Vernooij <jelmer_at_samba.org> wrote:
> At the moment a generic error (175002, SVN_ERR_RA_DAV_REQUEST_FAILED) is
> returned when ra_neon hits a 403 error, and this makes it hard to
> distinguish it from other RA errors that also return 175002.
>
> [[[
>
>  * subversion/include/svn_error_codes.h: Add error code
> SVN_ERR_RA_FORBIDDEN.
>  * subversion/libsvn_ra_neon/util.c(generate_error): Return
> SVN_ERR_RA_FORBIDDEN for 403 HTTP codes.
>
> ]]]
>
> Is SVN_ERR_RA_FORBIDDEN the right name here and RA the right category,
> or does it belong in the DAV specific error category?

Jelmer, I too favor a more specific error here (and think that the
top-level RA_ namespace is appropriate). However, how would this new
error code be differentiated from:

  SVN_ERRDEF(SVN_ERR_RA_NOT_AUTHORIZED,
             SVN_ERR_RA_CATEGORY_START + 1,
             "Authorization failed")

Is this specific to a case where you've already authenticated, and
your current ACL isn't sufficient to access a resource? Don't we just
prompt for re-authentication in this case?

- Dan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1313675
Received on 2009-03-12 18:21:40 CET