> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato_at_collab.net]
> Sent: donderdag 12 maart 2009 14:49
> To: Bert Huijben
> Cc: 'Senthil Kumaran S'; dev_at_subversion.tigris.org
> Subject: Re: [PATCH] Fix issue #2068
>
> Bert Huijben wrote:
> >> -----Original Message-----
> >> From: Senthil Kumaran S [mailto:senthil_at_collab.net]
> >> Sent: donderdag 12 maart 2009 10:09
> >> To: dev_at_subversion.tigris.org
> >> Subject: [PATCH] Fix issue #2068
> >>
> >> Hi,
> >>
> >> The attached patch gives a solution to fix issue #2068, though this is not
> >> backward compatible with earlier versions of subversion.
> >>
> >> [[[
> >> Fix issue #2068.
> >>
> >> NOTE: This is not backward compatible.
> >>
> >> * subversion/libsvn_subr/config_file.c
> >> (svn_config_ensure): Change the delimiter between properties to '|'
> >> from ';' in default config file.
> >
> > Maybe we should use a double semicolon as escape sequence for passing a
> > semicolon. I don't like the idea of breaking all old config files, registry
> > settings, etc..
>
> <span value="$0.02">I would much more prefer that we stick with some more
> commonly used escape character, such as the backslash (\), in any places
> where that character can't be reasonably interpreted as a Windows directory
> separator.</span>
I agree that the '\' is a very common escape, but in this case we used to parse everything except the semicolon as value, so I think the semicolon is the only character we can use 100% fully backwards compatible. But maybe \; is so uncommon we could use that too, but I'm not sure if using \ as escape for every character would be wise.
It is very hard to introduce an escape when you previously accepted everything as valid :(
Bert
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1313139
Received on 2009-03-12 15:36:54 CET