Re: Merge tracking: MyServer equals Myserver

On Wed, Mar 11, 2009 at 04:19:19PM +0100, Bert Huijben wrote:
> I don't think this patch simply handles the case where a single repository
> is available as svn://server/repos/ and http://server/svn/repos/ (note the
> /svn/ part)... Which will past through this test anyway. (Same case as a
> patch a few months ago)

I'm not sure I understand what you are saying.
Pass through which test in what way?

Do you mean the patch does not handle the case where two URLs
don't match after the hostname part? I think it does handle it,
and it looks like in this particular piece of code, Subversion
does handle this, with or without my patch. Or am I missing something?

Maybe you are talking about a different problem?
Another code path where we make another similar mistake that
causes Subversion to not see the same repository just because
it has two different URLs pointing to the same repository?

> I'm not sure if we should rely only on the UUID being the same to just
> accept it is the same repository...

Why even have a Universal Unique IDentifier if we're not using it as such?

> I remember a case where somebody just
> duplicated empty repositories instead of creating empty ones. (Well, that is
> his problem anyway...)

Yes, that is their problem. Tool used wrong. If I hit my thumb
with the hammer, I don't run to the manufacturers and ask them
to fix the hammer. It's my own fault because I didn't use the
tool right.

> In most code paths we verify whether the repository is the same by checking
> the UUID.. And this continues to replace this usage by using the uuid as the
> primary key on what a repository is, instead of the Url.

Yes, that is the whole point. What is wrong with that?
A given repository may have more than one URL pointing at
it so using URLs as primary keys does not work.

URLs are just a convenient ways for users to refer to a
repository with a unique UUID, aren't they?

Stefan
Received on 2009-03-11 16:58:30 CET