On Tue, Mar 10, 2009 at 14:56, Branko Cibej <brane_at_xbc.nu> wrote:
> Bert Huijben wrote:
>>> Isn't the whole point of the test suite to identify bugs? So, if you
>>> unconditionally Skip a test that fails on some platforms, it'll never
>>> get fixed because it'll never get run, and no-one ever reviews skipped
>>> tetss. Might as well remove the test then, what's the point?
>>>
>>> Or maybe fix the bug, who knows.
>>>
>>
>> Windows fails, mac-os partly passes, one linux buildbot passes, another linux buildbot fails.. (Unrelated to filesystem, ra layer, etc.)
>>
>> Which check would you like to apply?
>>
>>
>> These tests were merged to trunk in a broken state from the svnpatch branch and they hinder the other work that is going on. The buildbots are there to identify errors.. But until these tests are passing on all platforms they hide all the other new errors.
>>
>
> Ok, this may sound too pontificating, but I have to ask ... why was the
> merge even committed if it creates new errors?
Because they all passed for Arfrever.
> We agreed not too long
> ago that we'd agreed a long time ago that trunk should be stable ... or
> at least that tests on trunk should pass.
Totally agreed. See previous note.
> (Why the svnpatch thing should be system-specific is curious, too ...
> suspicious even.)
Bert said the tests apparently rely on GNU "patch" output specifics.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1303226
Received on 2009-03-10 15:12:56 CET