[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Patch management (was: Re: [PATCH] patch for links.html, added svn2svn)

From: Daniel Doubrovkine <dblock_at_dblock.org>
Date: Mon, 2 Mar 2009 17:14:18 -0500

I think you should simply reject a patch that's not cross-platform for
components of subversion that are cross-platform.

-----Original Message-----
From: Gavin 'Beau' Baumanis [mailto:gavinb_at_thespidernet.com]
Sent: Monday, March 02, 2009 5:12 PM
To: Daniel Shahaf
Cc: dB.; dev_at_subversion.tigris.org; John Peacock
Subject: Re: Patch management (was: Re: [PATCH] patch for links.html,
added svn2svn)

Hi Daniel- and everyone else , of course!
>
>> or,
>>
>> Is it simply a case of - we're all volunteers (primarily) so if
>> someone wants to make a *nix version of the patch they will - and in
>> the meantime the OP is more than supported by the group providing
>> assistance peer-review / assistance in patching their own installs
>> and
>> thus there is nothing more for me to do, aside from checking if there
>> is any life left in the patch proposal?
>>
>
> I don't understand the question. If we asked the OP to make some
> changes (e.g.: fix a portability bug) and resubmit the patch, and he
> hasn't, you can ping the thread and ask for an update. Is that what
> you
> asked?
>>

Ultimately, you already answered my question in a previous part of the
post but just to clarify;

(and while similar to the original posting of Daniel's - it turns out
it is different - and it may well be that it is something that's not
likely to ever happen)

Let's assume, I have written a patch to address an issue that I am
having in subversion.
But it only works for me, using my peculiar build / flavour of SVN -
let's just go with Windows for this example.

If there was a requirement for a *nix port of my patch someone else
would have to do it - other than me.

It gets reviewed by someone on the list - who points out that it will
only work on Windows, after which there is no more discussion.
No one has volunteered to do the *nix work and I can't do it for myself.

Thus, as the patch manager - do I bring it back to people's attention
and see if "I" can drum up support for someone to do the required
work - or is it a case of , well we're volunteering our time - so if
it gets done - well that's great ... but if it doesn't too bad and
there is nothing more for me to do (as Patch Manager) - obviously no
one else in interested / worried about the Windows only patch)?

Now saying all that , by answering some of the earlier paragraphs, it
would seem to be appropriate for me to bring it back into the
foreground for some further discussion - even if it turned out to be
along the lines of;
"This really isn't an issue for anyone else - and we have higher
priorities to address - archive it off, for now at least, anyway"

And again thanks for the help.

Beau,.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1258481
Received on 2009-03-03 15:56:19 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.