Re: svn commit: r36241 - trunk/subversion/libsvn_wc

On Mon, Mar 2, 2009 at 12:11, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
>...
> +++ trunk/subversion/libsvn_wc/status.c Mon Mar  2 03:11:09 2009        (r36241)
> @@ -281,7 +281,7 @@ assemble_status(svn_wc_status2_t **statu
>       if (entry && entry->url)
>         abs_path = entry->url + strlen(repos_root);
>       else if (parent_entry && parent_entry->url)
> -        abs_path = svn_path_join(parent_entry->url + strlen(repos_root),
> +        abs_path = svn_uri_join(parent_entry->url + strlen(repos_root),
>                                 svn_dirent_basename(path, pool), pool);

Maybe use svn_path_url_add_component2() ? ... that basename isn't encoded.

Which leads to a question... maybe our uri_is_canonical() should try
to ensure that the URI is encoded properly?

And another meta issue: URI is a poor name. The functions only deal with URLs.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1255935
Received on 2009-03-02 12:37:59 CET