[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] reenable libtool options

From: Philip Martin <philip_at_codematters.co.uk>
Date: Sun, 01 Mar 2009 12:41:24 +0000

Greg Stein <gstein_at_gmail.com> writes:

> We should move *forward*, not backward. If we want something fixed,
> then we fix it. 36153 fixed things. Reverting it will go back to the
> brokenness that caused Justing to fix it in the first place.

Instead of 36153 the brokenness could have been fixed with a patch
like:

Index: ../src/configure.ac
===================================================================
--- ../src/configure.ac (revision 36152)
+++ ../src/configure.ac (working copy)
@@ -173,6 +173,7 @@
   AS_HELP_STRING([--enable-experimental-libtool],[Use APR's libtool]),
   [experimental_libtool=$enableval],[experimental_libtool=no])
 
+ifdef([LT_INIT],[LT_INIT],[AC_PROG_LIBTOOL])
 if test "$experimental_libtool" = "yes"; then
   echo "using APR's libtool"
   sh_libtool="`$apr_config --apr-libtool`"
@@ -181,8 +182,6 @@
 else
   sh_libtool="$abs_builddir/libtool"
   SVN_LIBTOOL="\$(SHELL) $sh_libtool"
- dnl libtoolize requires that the following line not be indented
-ifdef([LT_INIT], [LT_INIT], [AC_PROG_LIBTOOL])
 fi
 AC_SUBST(SVN_LIBTOOL)

Justin feels that is not acceptable, I'm not really sure why but I
think it's because it creates libtool dropping in the build dir.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1250189
Received on 2009-03-01 13:41:41 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.