[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36171 - in trunk/subversion/bindings/swig: include ruby/svn ruby/test

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Fri, 27 Feb 2009 18:10:12 -0800

On Fri, Feb 27, 2009 at 6:58 AM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> On Feb 27, 2009, at 12:05 AM, Joe Swatosh wrote:
>
>> Author: joeswatosh
>> Date: Thu Feb 26 22:05:28 2009
>> New Revision: 36171
>>
>> Log:
>> Fix failing Ruby bindings test in the spirit of the fix for Python
>> in r21423:
>> "Fix segfault in Python tests by deleting the broken argout typemap
>> for the
>> 'result_digest' parameter in svn_txdelta_apply. Instead, ignore the
>> parameter
>> altogether."
>>
>> Updated to follow djames recommendation to not create an unused
>> temporary.
>>
>> * subversion/bindings/swig/include/svn_types.swg
>> (result_digest): Remove typemap for Ruby. Instead, ignore
>>  the parameter.
>> * subversion/bindings/swig/ruby/svn/delta.rb
>> (Svn::Delta.apply): Don't expect a digest to be returned by
>>  Svn::Delta.txdelta_apply_wrapper and don't return it.
>> * subversion/bindings/swig/ruby/test/test_delta.rb
>> (SvnDeltaTest#test_apply): Don't expect a digest returned with the
>> handler
>>  from Svn::Delta.apply.
>>
>> Reviewed by: djames
>>             hwright
>
> Heh.  I don't recall actually reviewing this, just saying something
> like "if you think it improves the state of the world, it can't hurt."
>

Sorry I misinterpreted you.

Has it improved the state of the world? :-)

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1242142
Received on 2009-02-28 03:10:34 CET

This is an archived mail posted to the Subversion Dev mailing list.