[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36175 - trunk/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 27 Feb 2009 10:31:59 -0600

On Feb 27, 2009, at 9:52 AM, Greg Stein wrote:

> 36167 encodes the repos_relpath (not the root).
>
> 36175 notes that the root should already be encoded, so that it can be
> joined with an encoded repos_relpath.
>
> yes?

tru dat.

>
> On Fri, Feb 27, 2009 at 16:01, Hyrum K. Wright
> <hyrum_wright_at_mail.utexas.edu> wrote:
>> On Feb 27, 2009, at 5:14 AM, Greg Stein wrote:
>>
>>> Author: gstein
>>> Date: Fri Feb 27 03:14:03 2009
>>> New Revision: 36175
>>>
>>> Log:
>>> * subversion/libsvn_wc/wc-metadata.sql:
>>> (REPOSITORY.root): as a follow-on to r36167, note that the column's
>>> value is URI-encoded.
>>> (REPOSITORY.uuid): remove the UNIQUE flag. a UUID may appear
>>> multiple
>>> times at different URLs.
>>> (I_UUID): remove UNIQUE flag, as above.
>>> (WORKING_NODE.moved_to): note this column is a local_relpath.
>>>
>>> Modified:
>>> trunk/subversion/libsvn_wc/wc-metadata.sql
>>>
>>> Modified: trunk/subversion/libsvn_wc/wc-metadata.sql
>>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/wc-metadata.sql?pathrev=36175&r1=36174&r2=36175
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/subversion/libsvn_wc/wc-metadata.sql Fri Feb 27
>>> 00:31:15
>>> 2009 (r36174)
>>> +++ trunk/subversion/libsvn_wc/wc-metadata.sql Fri Feb 27
>>> 03:14:03
>>> 2009 (r36175)
>>> @@ -37,14 +37,16 @@
>>> CREATE TABLE REPOSITORY (
>>> id INTEGER PRIMARY KEY AUTOINCREMENT,
>>>
>>> - /* the root URL of the repository */
>>> + /* The root URL of the repository. This value is URI-encoded. */
>>> root TEXT UNIQUE NOT NULL,
>>>
>>
>> Huh? r36167 uri encoded this value as it came *out* the database,
>> since it isn't currently being stored that way. If the above comment
>> were true, r36167 would have been pointless.
>>
>>
>>> /* the UUID of the repository */
>>> - uuid TEXT UNIQUE NOT NULL
>>> + uuid TEXT NOT NULL
>>> );
>>>
>>> -CREATE UNIQUE INDEX I_UUID ON REPOSITORY (uuid);
>>> +/* Note: a repository (identified by its UUID) may appear at
>>> multiple URLs.
>>> + For example, http://example.com/repos/ and https://example.com/repos/
>>> . */
>>> +CREATE INDEX I_UUID ON REPOSITORY (uuid);
>>>
>>>
>>> /*
>>> ------------------------------------------------------------------------- */
>>> @@ -216,8 +218,8 @@ CREATE TABLE WORKING_NODE (
>>> moved_from TEXT,
>>>
>>> /* If the underlying node was moved (rather than just deleted),
>>> this
>>> - specifies where the BASE node was moved to. This is set only
>>> on the
>>> - root of a move, and implied for all children.
>>> + specifies the local_relpath of where the BASE node was moved
>>> to.
>>> + This is set only on the root of a move, and implied for all
>>> children.
>>>
>>> Note that moved_to never refers to *this* node. It always
>>> refers
>>> to the "underlying" node, whether that is BASE or a child node
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1238135
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1239292
>>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1239659
Received on 2009-02-27 17:32:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.