[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Segfault in ruby tests

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Thu, 26 Feb 2009 22:10:51 -0800

On Tue, Feb 24, 2009 at 2:34 PM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
>
>

>
> The only place I see this particular failure is the buildbot.  I can't even
> reproduce it locally on the same box, using the same setup as the buildbot.
>  I've applied the patch locally, but get the same no-failure result as I do
> without the patch.  Funny business indeed.
>
> That being said, if you think this patch improve the state of the world, I
> see no reason it shouldn't be committed.
>

And

On Sat, Feb 21, 2009 at 9:06 AM, David James <james82_at_gmail.com> wrote:
>

>
> I haven't tested the patch, but it looks good in theory. One comment
> (see below):
>

> I don't think the variable "temp" is needed here anymore. This comment
> also applies to the Python version (I added this unused variable
> accidentally in r21423).

Good point.

> Anyway, if the test suite passes with your change, I say it is a good
> idea to commit it, because it fixes a known memory corruption bug.
>

r36171

Thanks for reviewing.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1236923
Received on 2009-02-27 07:11:05 CET

This is an archived mail posted to the Subversion Dev mailing list.