[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Blame to Working copy version (Completing issue #2544)

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Fri, 27 Feb 2009 00:06:39 +0100

Hi,

I just completed implementing working copy version support for blame on the
svn_client layer (where I intend to use it from my Subversion Client). To
make this command accessible from the commandline client I can do two
things.

1) Update the default end revision for passed paths to
svn_opt_revision_working
svn blame <file> would then use r0 - WORKING
And you could use
svn blame <file> -r 1:BASE for the current behavior

This is by far the easiest change, but would give a different result than
Subversion 1.0-1.6 when the local copy is modified.
 
Index: subversion/svn/blame-cmd.c
===================================================================
--- subversion/svn/blame-cmd.c (revision 36166)
+++ subversion/svn/blame-cmd.c (working copy)
@@ -312,7 +312,7 @@
           else if (svn_path_is_url(target))
             opt_state->end_revision.kind = svn_opt_revision_head;
           else
- opt_state->end_revision.kind = svn_opt_revision_base;
+ opt_state->end_revision.kind = svn_opt_revision_working;
         }
 
       if (opt_state->xml)

2) As the revision arguments don't allow specifying the WORKING revision,
the only other option would be to add a special argument. (Suggestion:
--blame-working).

I would suggest using option 1, but I'm not sure if this would be a breaking
change of the cli behavior?
(I think we might call it a bug fix)

Suggestions?

If nobody objects I intend to apply the option 1 patch.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1235404
Received on 2009-02-27 00:21:11 CET

This is an archived mail posted to the Subversion Dev mailing list.