[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'hotcopy' chokes

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 23 Feb 2009 09:46:15 -0600

On Feb 21, 2009, at 5:44 AM, Daniel Shahaf wrote:

> On my mirror of the repos, I see:
>
> % svnadmin hotcopy svn svn2
> svnadmin: Source 'svn\db\revs\1000.pack' is not a directory
>
>
> A quick look suggests that the fix (a follow-up to my r35523) might be
>
> [[[
> Index: fs_fs.c
> ===================================================================
> --- fs_fs.c (revision 36028)
> +++ fs_fs.c (working copy)
> @@ -1448,7 +1448,8 @@
> /* First, copy packed shards. */
> for (rev = 0; rev < min_unpacked_rev; rev += max_files_per_dir)
> {
> - const char *packed_shard = apr_psprintf(iterpool, "%ld.pack",
> rev);
> + const char *packed_shard = apr_psprintf(iterpool, "%ld.pack",
> + rev /
> max_files_per_dir);
> const char *src_subdir_packed_shard;
> src_subdir_packed_shard = svn_path_join(src_subdir,
> packed_shard, pool);
>
> ]]]

The patch looks reasonable, but I haven't tested it either. Is there
some unit test which tickles this bug?

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1215189
Received on 2009-02-23 16:46:37 CET

This is an archived mail posted to the Subversion Dev mailing list.