[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35916 - branches/explore-wc/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 17 Feb 2009 09:02:25 +0100

To clarify: those failures are on the "explore-wc" branch.

Right now, the branch is *not* using .svn/entries at all, but *just*
the sqlite database. Those failures represent a mismatch in
functionality between the two storage systems. hwright has been
working on reducing the count to zero which will imply feature-parity.

Separately, I've been merging bits from the branch back to trunk.
Trunk is *still* fully operational and passes all tests.


On Tue, Feb 17, 2009 at 08:51, Greg Stein <gstein_at_gmail.com> wrote:
> And with this change:
> 336 tests FAILED
> 1 tests XPASSED
> Quite a drop from the 407 failures!!
> Cheers,
> -g
> On Tue, Feb 17, 2009 at 08:13, Greg Stein <gstein_at_gmail.com> wrote:
>> Author: gstein
>> Date: Mon Feb 16 23:13:58 2009
>> New Revision: 35916
>> Log:
>> On the explore-wc branch:
>> Fix some problems related to the propcaching removal.
>> Note that r35796 was partially-reverted. We want to keep the old
>> propcaching introduction stuff in lock.c.
>> * subversion/libsvn_wc/props.c:
>> (load_props): if we're loading WORKING props, then indicate when the
>> props are not present by returning NULL for the hash.
>> (svn_wc__load_props): load the base props if somebody asks for the
>> working props (if there are no mods, then WORKING is copied from BASE
>> props).
>> (svn_wc_prop_list): restore previous call to svn_wc__load_props(),
>> ignoring the overlay stuff. that was an attempt to compensate for the
>> original bug in svn_wc__load_props.
>> (svn_wc__has_props): also examine the BASE props. really old working
>> copies always had WORKING, but newer ones may not.
>> (svn_wc_props_modified_p): if there are no WORKING props, then there are
>> definitely no mods. if there are some, then load 'em up and do a full
>> examination.
>> * subversion/libsvn_wc/lock.c:
>> (introduce_propcaching): restore from r35796. add note that we need this
>> dance in order to toss out WORKING props if they're unchanged.
>> [ strictly speaking, we may not need to; safer for now tho ]
>> (maybe_upgrade_format): call introduce_propcaching when needed.
>> * subversion/libsvn_wc/old-and-busted.c:
>> (read_entry): ignore all the propcaching fields that may be saved.
>> (write_entry): write bupkis for the propcaching fields
>> (write_entry_xml): don't write attributes for propcaching fields
>> * subversion/libsvn_wc/entries.c:
>> (svn_wc__atts_to_entry): add comment about the deprecated fields
>> (svn_wc_entry_dup): fill in empty strings for the old propcach fields
>> * subversion/libsvn_wc/log.c:
>> (svn_wc__loggy_entry_modify): add comment about the deprecated fields
>> Modified:
>> branches/explore-wc/subversion/libsvn_wc/entries.c
>> branches/explore-wc/subversion/libsvn_wc/lock.c
>> branches/explore-wc/subversion/libsvn_wc/log.c
>> branches/explore-wc/subversion/libsvn_wc/old-and-busted.c
>> branches/explore-wc/subversion/libsvn_wc/props.c

Received on 2009-02-17 09:02:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.