[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Segfault in ruby tests

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Mon, 16 Feb 2009 22:30:05 -0800

On Thu, Jan 29, 2009 at 10:27 AM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Joe Swatosh wrote:
>>

blah, blah

>> I'm not much help. Maybe try running the tests with a -v so we will
>> at least know the name of the test that causes the segfault?
>
> hwright_at_orac:~/dev/svn-trunk/subversion/bindings/swig/ruby$ /usr/bin/ruby -I
> /home/hwright/dev/svn-trunk/subversion/bindings/swig/ruby
> /home/hwright/dev/svn-trunk/subversion/bindings/swig/ruby/test/run-test.rb
> -v
> Loaded suite .
> Started
> ...
> test_apply(SvnDeltaTest):
> /home/hwright/dev/svn-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:
> [BUG] Segmentation fault
> ruby 1.8.7 (2008-08-11 patchlevel 72) [x86_64-linux]
>
> The buildbot is back up, too, so you can see the error in the binding test
> output.

Since the tests are failing on the build bot again, I just wanted to
put this note out there (I don't know what to do with it yet):

[[[
D:\SVN\src-trunk>svn log -c21423
------------------------------------------------------------------------
r21423 | djames | 2006-09-11 09:48:15 -0700 (Mon, 11 Sep 2006) | 32 lines

Fix segfault in Python tests by deleting the broken
argout typemap for the 'result_digest' parameter in
svn_txdelta_apply. Instead, ignore the parameter
altogether.

svn_txdelta_apply should not return 'result_digest'
as a String, because the result digest is not ready
yet when svn.delta.tx_apply is finished. Instead,
we should probably allocate a StringIO buffer,
so that the user can check the return values as
needed.

(FIXME: We should define a compatibility policy for
 the SWIG bindings. svn_txdelta_apply is not the only
 function whose interface will need to be changed
 to make it actually work [i.e., not segfault]. If
 we actually made an "official list" of the tested
 APIs, with documentation, it would probably be quite
 useful for both users and developers. I'm +1 on
 defining any semi-broken APIs, such as this one,
 as "experimental, and subject to change".)

* subversion/bindings/swig/include/svn_types.swg
  (result_digest): Remove typemap. Instead, ignore
  the parameter.

* subversion/bindings/swig/python/tests/delta.py:
  Adjust to compensate for removed 'digest'
  parameter.

------------------------------------------------------------------------
]]]

Good night.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1176577
Received on 2009-02-17 07:30:24 CET

This is an archived mail posted to the Subversion Dev mailing list.