[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Q about the delta editor interface

From: Philipp Marek <philipp.marek_at_emerion.com>
Date: Mon, 16 Feb 2009 08:40:59 +0100

Hello everybody,

I just stumbled on the delta editors' interface definition (about
add_directory):
  /** We are going to add a new subdirectory named @a path. We will use
   * the value this callback stores in @a *child_baton as the
   * @a parent_baton for further changes in the new subdirectory.
  ...

That's means (IMO) that the hierarchy gets described by the *baton* hierarchy;
but a simple test shows that it's more the *paths* that define the way the
entries are coupled.

To clarify:
I wrote a recursive function that gives the new baton to the subsequent calls,
and that uses "dir-a", "dir-b", "dir-c" etc. as path parameter.
This shows that these directories get created in the commit base directory,
and not nested like the batons suggest.

Now I know that it works by using the full paths, and that the full paths are
a bit easier to use for the libraries (because they don't have to build the
whole paths from the individual levels) - but it's a little bit nagging at me
(and it makes it much harder to implement a feature I'm currently at).

So, again - there's no hope to change that (because there are too many
consumers of this API, and revving it just because of that doesn't seem worth
the effort) - but is it only me that feels a bit uneasy? Any opinions?

Regards,

Phil
Received on 2009-02-16 08:41:39 CET

This is an archived mail posted to the Subversion Dev mailing list.