[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35824 - branches/explore-wc/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 14 Feb 2009 04:27:08 +0100

On Thu, Feb 12, 2009 at 07:17, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>...
> @@ -2141,28 +2091,12 @@ svn_wc_prop_list(apr_hash_t **props,
> SVN_ERR(svn_wc_adm_retrieve(&adm_access, adm_access,
> svn_path_dirname(path, pool), pool));
>
> - return svn_wc__load_props(NULL, props, NULL, adm_access, path, pool);
> -}
> -
> -/* Determine if PROPNAME is contained in the list of space separated
> - values STRING. */
> + SVN_ERR(svn_wc__load_props(&base_props, &new_props, NULL, adm_access,
> + path, pool));
>
> -static svn_boolean_t
> -string_contains_prop(const char *string, const char *propname)
> -{
> - const char *place = strstr(string, propname);
> - int proplen = strlen(propname);
> + *props = apr_hash_overlay(pool, new_props, base_props);

I don't understand why the logic changed here. The removal of the
propcaching should not have affected the original svn_wc__load_props()
call. So why the addition of the overlay here?

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1155020
Received on 2009-02-14 04:27:31 CET

This is an archived mail posted to the Subversion Dev mailing list.