[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35510 - branches/explore-wc/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 14 Feb 2009 03:45:25 +0100

On Tue, Jan 27, 2009 at 22:50, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>...
> @@ -1981,7 +1987,39 @@ insert_actual_node(svn_sqlite__db_t *wc_
> db_actual_node_t *actual_node,
> apr_pool_t *scratch_pool)
> {
> - return SVN_NO_ERROR;
> + svn_sqlite__stmt_t *stmt;
> + svn_stringbuf_t *properties;
> + svn_skel_t *skel;

const on PROPERTIES and SKEL ?

>...
> @@ -2021,6 +2059,42 @@ write_entry(svn_stringbuf_t *buf,
>...
> + if (entry->incomplete)
> + {
> + base_node = MAYBE_ALLOC(base_node, scratch_pool);
> + /* TODO: how do we find the exact number of incomplete children? */
> + base_node->incomplete_children = 1;

Answer: we don't. That was intended to be a boolean value.
(wc-metadata.sql needs clarification)

Maybe it should be a count? But I think we simply need a boolean to
indicate "not ready; tread carefully".

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1154901
Received on 2009-02-14 03:45:40 CET

This is an archived mail posted to the Subversion Dev mailing list.