[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35115 - in trunk/subversion: include libsvn_client libsvn_delta libsvn_fs libsvn_fs_base libsvn_fs_base/bdb libsvn_fs_base/util libsvn_fs_fs libsvn_subr libsvn_wc tests/libsvn_delta

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 14 Feb 2009 01:59:31 +0100

On Wed, Feb 11, 2009 at 23:59, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
> On Fri, Jan 9, 2009 at 4:21 PM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
>> Author: julianfoad
>> Date: Fri Jan 9 07:21:26 2009
>> New Revision: 35115
>>
>> Log:
>> Revert r35103 because making the svn_checksum_t type opaque was unnecessary
>> obstruction, as suggested by gstein in the email thread
>> <http://svn.haxx.se/dev/archive-2009-01/0226.shtml>.
>>
>> The log message of r35103 was:
>> In the "checksums" API, make the svn_checksum_t type opaque to help make
>> future extensions easier, and introduce accessor functions [...]
>> Make the constructor "svn_checksum__from_digest()" public [...]
>>
>
>> Modified: trunk/subversion/include/svn_checksum.h
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_checksum.h?pathrev=35115&r1=35114&r2=35115
>> ==============================================================================
>> --- trunk/subversion/include/svn_checksum.h Fri Jan 9 07:05:31 2009 (r35114)
>> +++ trunk/subversion/include/svn_checksum.h Fri Jan 9 07:21:26 2009 (r35115)
>> @@ -48,7 +48,15 @@ typedef enum
>> *
>> * @since New in 1.6.
>> */
>> -typedef struct svn_checksum_t svn_checksum_t;
>> +typedef struct svn_checksum_t
>> +{
>> + /** The bytes of the checksum. */
>> + const unsigned char *digest;
>> +
>> + /** The type of the checksum. This should never be changed by consumers
>> + of the APIs. */
>> + svn_checksum_kind_t kind;
>> +} svn_checksum_t;
>>
>> /**
>> * Opaque type for creating checksums of data.
>> @@ -192,34 +200,18 @@ svn_checksum_final(svn_checksum_t **chec
>> * @since New in 1.6.
>> */
>> apr_size_t
>> -svn_checksum_get_size(const svn_checksum_t *checksum);
>> +svn_checksum_size(svn_checksum_t *checksum);
>>
>> -/**
>> - * Return a (read-only) pointer to the binary digest of @a checksum.
>> - *
>> - * @since New in 1.6.
>> - */
>> -const unsigned char *
>> -svn_checksum_get_digest(const svn_checksum_t *checksum);
>> -
>> -/**
>> - * Return the checksum kind of @a checksum.
>> - *
>> - * @since New in 1.6.
>> - */
>> -svn_checksum_kind_t
>> -svn_checksum_get_kind(const svn_checksum_t *checksum);
>>
>> /**
>> - * Create a checksum from a binary digest @a digest of kind @a kind.
>> - * Allocate the result in @a pool, making a deep copy of @a digest.
>> + * Internal function for creating a checksum from a binary digest.
>> *
>> * @since New in 1.6
>> */
>> svn_checksum_t *
>> -svn_checksum_from_digest(const unsigned char *digest,
>> - svn_checksum_kind_t kind,
>> - apr_pool_t *result_pool);
>> +svn_checksum__from_digest(const unsigned char *digest,
>> + svn_checksum_kind_t kind,
>> + apr_pool_t *result_pool);
>
> Why is this 'internal' function in a public header?
>
> Which is it? private or public?

Private. If you'd like to create a private/checksum.h to hold that one
declaration... :-)

I think that I put that declaration there. Or made it private or
something. Don't recall exactly. But to be honest, it is there (rather
than a private header) out of simple laziness :-P

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1154378
Received on 2009-02-14 01:59:46 CET

This is an archived mail posted to the Subversion Dev mailing list.