[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35746 - in trunk/subversion: include libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 9 Feb 2009 06:22:07 -0800

On Sun, Feb 8, 2009 at 16:15, Bert Huijben <rhuijben_at_sharpsvn.net> wrote:
> Author: rhuijben
> Date: Sun Feb 8 16:15:58 2009
> New Revision: 35746
>
> Log:
> Following up on r35743, fix whitespace and move encoding comment to
> header file.
>
> * subversion/include/svn_io.h
> (svn_io_run_diff, svn_io_run_diff3_2):
> Document that diff_cmd must be cstring encoded.

Woah. That is dangerous for our public APIs. All of our public APIs
are supposed to be UTF-8. That's the primary reason for all the
svn_io_* wrappers around APR: make them all UTF-8.

Second, "cstring" doesn't tell me anything. Our utf-8-encoded strings
are cstrings, too. You mean something more like "native, local-style"
or something like that. I've seen that in headers before.

But I still think it's bad precedent to expose this in the API.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1129252
Received on 2009-02-09 15:22:41 CET

This is an archived mail posted to the Subversion Dev mailing list.