Re: Segfault in ruby tests

On Thu, Feb 5, 2009 at 7:41 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
> On Thu, Feb 5, 2009 at 1:52 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
>> On Sat, Jan 31, 2009 at 12:45 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
>>> Hi,
>>>
>>> In <497F4B21.5030008_at_mail.utexas.edu>
>>> "Segfault in ruby tests" on Tue, 27 Jan 2009 11:57:53 -0600,
>>> "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> wrote:
>>>
>>>> The ruby bindings tests are segfaulting on the buildbot. I can reproduce locally:
>>>
>>> I don't know about the detail of the problem but this patch
>>> will solve the problem:
>>>
>
>
>>>
>>
>> In the spirit of kou's patch, but in the bindings area:
>>
>> Index: subversion/bindings/swig/svn_delta.i
>> ===================================================================
>> --- subversion/bindings/swig/svn_delta.i (revision 35664)
>> +++ subversion/bindings/swig/svn_delta.i (working copy)
>> @@ -232,8 +232,10 @@
>> void **handler_baton,
>> apr_pool_t *pool)
>> {
>> + apr_pool_t *sub_pool = sub_pool = svn_pool_create(pool);
>> svn_txdelta_apply(source, target, result_digest, error_info,
>> pool, handler, handler_baton);
>> + svn_pool_destroy(sub_pool);
>> }
>>
>> static svn_error_t *
>>
>
> Doh! Of course I meant:
>
> Index: subversion/bindings/swig/svn_delta.i
> ===================================================================
> --- subversion/bindings/swig/svn_delta.i (revision 35665)
> +++ subversion/bindings/swig/svn_delta.i (working copy)
> @@ -232,8 +232,10 @@
> void **handler_baton,
> apr_pool_t *pool)
> {
> + apr_pool_t *sub_pool = sub_pool = svn_pool_create(pool);
> svn_txdelta_apply(source, target, result_digest, error_info,
> - pool, handler, handler_baton);
> + sub_pool, handler, handler_baton);
> + svn_pool_destroy(sub_pool);
> }
>
> static svn_error_t *
>

Never mind, now that I can build again, this causes a segfault locally.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1110621