[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35631 - in trunk/subversion: libsvn_client libsvn_fs_base libsvn_fs_base/bdb libsvn_fs_base/util libsvn_fs_fs libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos libsvn_subr libsvn_wc mod_dav_svn svn svnlook svnserve tests/libsvn_subr

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 04 Feb 2009 18:32:52 +0000

Martin Furter wrote:
> Index: trunk/subversion/libsvn_subr/sqlite.c
[...]
> - return (sqlite3_column_int64(stmt->s3stmt, column) == 0
> - ? FALSE : TRUE);
> + return (sqlite3_column_int64(stmt->s3stmt, column) == 0);
[...]
> No matter how long I stare at this one, it still looks wrong to me.
> Shouldn't it be !=0 instead of ==0 ?

Yes, you're right. Thanks ever so much for finding my mistake.

Fixed in r35675.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1103301
Received on 2009-02-04 19:33:18 CET

This is an archived mail posted to the Subversion Dev mailing list.