[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 3227 - adding some extra "custom" headers to the email

From: Jon Bendtsen <jbendtsen_at_laerdal.dk>
Date: Wed, 4 Feb 2009 17:50:01 +0100

On 27/01/2009, at 12.26, Jon Bendtsen wrote:

> On 26/01/2009, at 15.33, Greg Stein wrote:

[cuuuuuuuuuuuuuut]

>> I would also suggest *not* allowing two "..." segments. I don't see
>> any utility in that, so would disallow it.
>
> Actually i dont mind 2 ... because i start from the front and stop
> once i reach the end of the list or the first ...
> Then i start from the rear and continue until either ... or the
> beginning of the list.
> I did not plan to test for 2 ...

Here is a patch against trunk, rev 35671. I tried to make it robust,
and i can not think of any more tests that crashes it.

i now move the paths down to where i make the headers, and only
there do i parse the paths and the configuration to avoid moving
arround too many variables.

JonB

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1102884

On 27/01/2009, at 12.26, Jon Bendtsen wrote:

> On 26/01/2009, at 15.33, Greg Stein wrote:

[cuuuuuuuuuuuuuut]

>> I would also suggest *not* allowing two "..." segments. I don't see
>> any utility in that, so would disallow it.
>
> Actually i dont mind 2 ... because i start from the front and stop
> once i reach the end of the list or the first ...
> Then i start from the rear and continue until either ... or the
> beginning of the list.
> I did not plan to test for 2 ...

Here is a patch against trunk, rev 35671. I tried to make it robust,
and i can not think of any more tests that crashes it.

i now move the paths down to where i make the headers, and only
there do i parse the paths and the configuration to avoid moving
arround too many variables.

JonB

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1102884

Received on 2009-02-04 19:30:07 CET

This is an archived mail posted to the Subversion Dev mailing list.