Stefan Sperling wrote:
> On Tue, Feb 03, 2009 at 03:06:15PM -0600, Hyrum K. Wright wrote:
>> Julian Foad wrote:
>>> Well, isn't the proper solution to use "make" to do this job, instead of
>>> a manual step in "autogen"? (This is about re-making a target file from
>>> a source file if it's out of date or doesn't yet exist, which is exactly
>>> the purpose of "make".) Is there any reason this step needs to be done
>>> so early in the build process?
>> Not a deal breaker, but gen-make.py will complain if the referenced header file
>> doesn't exist. That's why I put this step in autogen.sh before gen-make.py is run.
>
> So gen-make.py complains about something that is not a problem?
> If so, making some fix to gen-make.py was not an option?
>
> I'd also think having make sort this stuff out, if at all possible,
> is a better solution. It's more portable.
One other caveat: the creation of the .h is currently done with a python script,
but we don't require people who build Subversion to have python installed,
though most probably do. I did it with python because it was easiest for me, if
somebody with more sed/awk skillz wants to improve it, go ahead.
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1099164
Received on 2009-02-04 00:07:01 CET