[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35631 - in trunk/subversion: libsvn_client libsvn_fs_base libsvn_fs_base/bdb libsvn_fs_base/util libsvn_fs_fs libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos libsvn_subr libsvn_wc mod_dav_svn svn svnlook svns

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 3 Feb 2009 19:01:42 +0100

On Mon, Feb 2, 2009 at 17:09, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> On Mon, 2009-02-02 at 08:05 -0800, Blair Zajac wrote:
>> Julian Foad wrote:
>> > Author: julianfoad
>> > Date: Mon Feb 2 07:56:44 2009
>> > New Revision: 35631
>> >
>> > Log:
>> > Replace the expressions "? TRUE : FALSE" and "? FALSE : TRUE", which are ugly
>> > and redundant or almost redundant, with more direct ways to express the
>> > boolean test that is meant, throughout the C code base. No functional change.
>> >
>> > The changes are similar to these:
>> > boolean ? TRUE : FALSE => boolean
>> > boolean ? FALSE : TRUE => ! (boolean)
>> > x == y ? TRUE : FALSE => x != y
>>
>> I haven't reviewed all the changes, but for the third one you mean
>>
>> x == y ? FALSE : TRUE => x != y
>
> Yes. Thanks. Just a log message typo, I hope. I've edited the log
> message.

All the changes look good, despite the log message :-P

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1097835
Received on 2009-02-03 19:02:05 CET

This is an archived mail posted to the Subversion Dev mailing list.