[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Fwd: Possible bug in build-system

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Tue, 3 Feb 2009 17:05:52 +0100

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad_at_btopenworld.com]
> Sent: dinsdag 3 februari 2009 17:00
> To: Hyrum K. Wright
> Cc: Mark Phippard; dev_at_subversion.tigris.org; Christian Fischer
> Subject: Re: Fwd: Possible bug in build-system

> > >
> > > Index: autogen.sh
> > > ===================================================================
> > > --- autogen.sh (revision 35640)
> > > +++ autogen.sh (working copy)
> > > @@ -113,7 +113,7 @@
> > >
> > > # Transform sql files into header files
> > > for file in subversion/libsvn_fs_fs/rep-cache-db.sql; do
> > > - if test $file -nt $file.h; then
> > > + if (test $file -nt $file.h) || !(test -e $file.h); then
> > > $PYTHON build/transform_sql.py $file
> > > fi
> > > done
> >
> > What shell are you using? I did a fresh checkout from trunk, ran
> autogen.sh and
> > configure, and didn't have any problem. rep-cache.sql.h was created
> as expected.
> >
> > That being said, it don't think that it hurts to have this patch
> included.
>
> A bit of research...
>
> The "-nt" test is not standard in the "test" utility, according to
> <http://www.qnxclub.net/files/articles/unix03/utilities/test.html>
> (search for "-nt" on that page). Sorry about that: I put that there.
>
> It is commonly available as part of the "[ ... ]" shell built-in alias
> for "test"... but I'm not sure how standard that is.
>
> However, when the "-nt" test is available, its definition (quoting from
> my "Bash" manual) is:
>
> file1 -nt file2
> True if file1 is newer (according to modification date)
> than file2, or if file1 exists and file2 does not.
>
> So, if the test is wrongly failing on the original poster's system, I'm
> not sure that the "or not exists..." patch is the right solution, even
> though it works in the case where the file is missing.

lgo reported this issue yesterday (or the day before) on irc using the
'dash' shell.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1097445
Received on 2009-02-03 17:06:49 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.