single file externals not working for binary files

Hi,

It looks like single file externals are not working for files that are
binary (or considered binary).

Below is a script that can be used to reproduce the problem. The script
is setting two externals: one for a normal text file and one for a file
with svn:mime-type set to application/octet-stream.

You can see that the latest svn up is failing to fetch the external of
the binary file with the error message: svn: warning: Unrecognized line
ending style. The text file is fetched correctly.

I am using revision 35485 of trunk on windows. I am running it in the
root dir of a drive.

Script:

svnadmin create repos

svn co file:///repos wc1

cd wc1

mkdir dir1

echo test > dir1\file1

echo test2 > dir1\file2

svn add dir1

svn mkdir dir2

svn propset svn:mime-type application/octet-stream dir1\file2

svn -m "1" commit

svn up

cd dir2

echo ../dir1/file1 file1 > externals.txt

echo ../dir1/file2 file2 >> externals.txt

svn propset -F externals.txt svn:externals .

cd ..

svn commit -m"2"

svn up

Output:

svnadmin create repos

svn co file:///repos wc1

Checked out revision 0.

cdd wc1

mkdir dir1

echo test > dir1\file1

echo test2 > dir1\file2

svn add dir1

A dir1

A dir1\file1

A dir1\file2

svn mkdir dir2

A dir2

svn propset svn:mime-type application/octet-stream dir1\file2

property 'svn:mime-type' set on 'dir1\file2'

svn -m "1" commit

Adding dir1

Adding dir1\file1

Adding (bin) dir1\file2

Adding dir2

Transmitting file data ..

Committed revision 1.

svn up

At revision 1.

cdd dir2

echo ../dir1/file1 file1 > externals.txt

echo ../dir1/file2 file2 >> externals.txt

svn propset -F externals.txt svn:externals .

property 'svn:externals' set on '.'

cdd ..

svn commit -m"2"

Sending dir2

Committed revision 2.

svn up

Fetching external item into 'dir2\file1'

E dir2\file1

Updated external to revision 2.

Fetching external item into 'dir2\file2'

svn: warning: Unrecognized line ending style

Updated to revision 2.

Regards,

Marc

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1095986
Received on 2009-02-03 10:50:41 CET