[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35597 - trunk/tools/dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Fri, 30 Jan 2009 23:20:55 +0100

2009-01-30 22:39:02 Greg Stein napisaƂ(a):
> On Fri, Jan 30, 2009 at 20:48, Arfrever Frehtes Taifersar Arahesis
> <Arfrever.FTA_at_gmail.com> wrote:
> > Author: arfrever
> > Date: Fri Jan 30 11:48:25 2009
> > New Revision: 35597
> >
> > Log:
> > Follow-up to r35585:
> >
> > * tools/dev/graph-dav-servers.py
> > (load_stats): Use list comprehension instead of map().
> >
> > Modified:
> > trunk/tools/dev/graph-dav-servers.py
> >
> > Modified: trunk/tools/dev/graph-dav-servers.py
> > URL: http://svn.collab.net/viewvc/svn/trunk/tools/dev/graph-dav-servers.py?pathrev=35597&r1=35596&r2=35597
> > ==============================================================================
> > --- trunk/tools/dev/graph-dav-servers.py Fri Jan 30 11:44:37 2009 (r35596)
> > +++ trunk/tools/dev/graph-dav-servers.py Fri Jan 30 11:48:25 2009 (r35597)
> > @@ -114,7 +114,7 @@ def get_ordinal_date(date):
> >
> > def load_stats():
> > dates = [get_ordinal_date(date) for date, value in STATS]
> > - counts = map(operator.itemgetter(1), STATS)
> > + counts = [operator.itemgetter(1)(x) for x in STATS]
>
> Okay... this could go either way. map() or comprehension. Fine...

map() returns an iterator in Python 3.

> BUT. If you're going to switch it to a comprehension, then *please*
> ... apply a bit of brain power first :-P
>
> counts = [x[1] for x in STATS]

Fixed in r35604.

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2009-01-30 23:23:38 CET

This is an archived mail posted to the Subversion Dev mailing list.