[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35161 - in trunk/subversion: bindings/javahl/native include libsvn_auth_gnome_keyring libsvn_subr tests/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 27 Jan 2009 12:42:21 +0100

The log message also helps us *review* the change, which is why we
have commit email in the first place. Not providing a log message
makes review very difficult -- we have no idea what the intent of the
change is, and whether the actual change matches that intent.

(this is similar to log messages that say "fixed foo()" without
describing what was broken)

Cheers,
-g

On Mon, Jan 12, 2009 at 16:38, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
>> Author: arfrever
>> Date: Sun Jan 11 20:31:13 2009
>> New Revision: 35161
>>
>> Log:
>> Various fixes. I will propedit svn:log later.
>
> I can understand the desire to get fixes of any kind into trunk, but not
> providing an accompanying log message is just plain lazy. :) If you didn't
> have the time to write a log message, how do I know you had time to test before
> committing?
>
> -Hyrum
>
>> Modified:
>> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>> trunk/subversion/include/svn_auth.h
>> trunk/subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>> trunk/subversion/libsvn_subr/auth.c
>> trunk/subversion/libsvn_subr/cmdline.c
>> trunk/subversion/tests/libsvn_subr/auth-test.c
> ...
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1019403
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1058633
Received on 2009-01-27 12:43:05 CET

This is an archived mail posted to the Subversion Dev mailing list.