Re: svn commit: r35480 - branches/http-protocol-v2/subversion/libsvn_ra_serf

On Mon, Jan 26, 2009 at 22:03, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>...
> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/property.c Mon Jan 26 13:03:28 2009 (r35480)
>...
> @@ -977,6 +956,32 @@ svn_ra_serf__get_baseline_info(const cha
> *bc_relative = svn_path_is_child(decoded_root, decoded_url, pool);
> SVN_ERR_ASSERT(*bc_relative != NULL);
> }
> +
> + if (latest_revnum)
> + {
> + svn_ra_serf__options_context_t *opt_ctx;
> + svn_error_t *err;
> +
> + svn_ra_serf__create_options_req(&opt_ctx, session, session->conns[0],
> + session->repos_url.path, pool);
> + err = svn_ra_serf__context_run_wait
> + (svn_ra_serf__get_options_done_ptr(opt_ctx), session, pool);

Remove the whitespace before the open-paren.

>...
> +++ branches/http-protocol-v2/subversion/libsvn_ra_serf/ra_serf.h Mon Jan 26 13:03:28 2009 (r35480)
>...
> +#define SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(sess) (sess->me_resource != NULL)

Should protect the SESS variable better:

 ((sess)->me_resource != NULL)

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1058496
Received on 2009-01-27 12:01:56 CET