[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35444 - trunk/tools/client-side

From: Fabien Coelho <fabien_at_coelho.net>
Date: Sun, 25 Jan 2009 09:31:46 +0100 (CET)

>>> Modified: trunk/tools/client-side/bash_completion
>>> + # outside IFS is not broken because the function is called in a
>>> subshell
>>> + IFS='
>>> +'
>>
>> Don't you have to reset IFS when you're done with it, or is the change
>> local to this function?
>
> I have already fixed it before reading your e-mail in r35445.

I think it is not needed in the context, and I've checked before
committing (or at least I think I checked:-).

As noted in the comment, the function is always called in a subshell to
parse svn status output, so in effect the IFS is local to the function.

However, there is no harm in resetting it. Moreover, if someone was to
execute the function directly, which does not make sense from a functional
point of view, it may indeed break the IFS.

So I'm fine with r35445, although ISTM that there was no bug.

-- 
Fabien
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1049112
Received on 2009-01-25 09:32:24 CET

This is an archived mail posted to the Subversion Dev mailing list.