[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35313 - in branches/http-protocol-v2: . subversion/mod_dav_svn subversion/mod_dav_svn/reports

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Wed, 21 Jan 2009 11:20:39 -0600

On Wed, Jan 21, 2009 at 10:28 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Greg Stein wrote:
>> On Sun, Jan 18, 2009 at 17:37, Ben Collins-Sussman <sussman_at_red-bean.com> wrote:
>>> ...
>>> +++ branches/http-protocol-v2/subversion/mod_dav_svn/repos.c Sun Jan 18 08:37:15 2009 (r35313)
>>> ...
>>> @@ -307,6 +307,36 @@ parse_vcc_uri(dav_resource_combined *com
>>>
>>>
>>> static int
>>> +parse_rootstub_uri(dav_resource_combined *comb,
>>> + const char *path,
>>> + const char *label,
>>> + int use_checked_in)
>>> +{
>>> + /* There are no components after the root stub, i.e. just
>>> + "!svn/me/".
>>
>> Is this true? That a trailing slash can/will exist? I thought this
>> resource was specified as NO trailing slash.
>>
>>> ...
>>
>> Changes like this one can/should appear on trunk. There is no reason
>> to hide this on the branch.
>
> I dunno, dude. With 1.6 looming in the near future, changes like this that
> bring no value to the trunk -- merely the risks associated with
> intended-to-be-but-not-really dead code -- are IMO unwelcome there.

Not only that, but it makes it very "clean" to have the v2 protocol
implemented in one place -- not in piecemeal changes scattered across
two different branches. I know our merge-tracking code is brilliant
and all, but... :-)

That said, once 1.6 is released and the v2 protocol is "mostly"
finished, I promise to merge the branch to trunk quickly. I'm not
going to wait till it's perfect before merging.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1041619
Received on 2009-01-21 18:21:30 CET

This is an archived mail posted to the Subversion Dev mailing list.