[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35328 - in trunk/subversion/mod_dav_svn: . reports

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 21 Jan 2009 11:41:31 -0500

Greg Stein wrote:
> On Mon, Jan 19, 2009 at 18:40, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> ...
>> +++ trunk/subversion/mod_dav_svn/reports/get-locks.c Mon Jan 19 09:40:49 2009 (r35328)
>> ...
>> + if ((apr_err = send_get_lock_response(locks, output, bb, resource->pool)))
>> + derr = dav_svn__convert_err(svn_error_create(apr_err, 0, NULL),
>> HTTP_INTERNAL_SERVER_ERROR,
>> - "Error flushing brigade.",
>> + "Error writing REPORT response.",
>> resource->pool);
>
> Gah. Use dav_new_error() please.

I'm looking at dav_new_error(), and I think there's an information loss to
be had if I use that:

dav_new_error() accepts:
  - the HTTP status code
  - what appears to be a magic DAV error code (which we always pass as
    0 from mod_dav_svn)
  - the error string
  - a pool

dav_svn__convert_err() accepts:
  - the HTTP status code
  - an svn_error_t *, from which is made a dav_error chain that seems to
    preserve apr_err)
  - the error string
  - a pool

So, by using the former, we appear to be losing a useful bit of information:
 the original apr_status_t value. Am I misunderstanding something?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1041569

Received on 2009-01-21 17:41:53 CET

This is an archived mail posted to the Subversion Dev mailing list.