[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 3227 - adding some extra "custom" headers to the email

From: Jon Bendtsen <jbendtsen_at_laerdal.dk>
Date: Wed, 21 Jan 2009 14:30:12 +0100

On 21/01/2009, at 14.04, Greg Stein wrote:

> On Wed, Jan 21, 2009 at 12:13, Greg Stein <gstein_at_gmail.com> wrote:
>> On Mon, Jan 19, 2009 at 16:37, Jon Bendtsen <jbendtsen_at_laerdal.dk>
>> wrote:
>>> Hi
>>>
>>> Here is a new patch that makes some small optimizations to avoid
>>> wasting space.
>>>
>>> <module> / <branch> / <submodule> / ... / <file>
>>>
>>> If branch is trunk it is not included, because default is assumed to
>>> be trunk
>>>
>>> if submodule and file are identical, only the file header is
>>> included.
>>>
>>> If the group is None, there is no X-group header.
>>
>> Hmm. Most repositories that I've seen do not have <module>. They just
>> start with /trunk. The above form only matches for the typical /tags
>> and /branches.
>>
>> Rather than applying specific names to the components, how about a
>> more general solution such as (for your example above):
>>
>> path-headers = module:0 branch:1 submodule:2 mysubsub:3 file:-1
>>
>> Or something like that. Basically: NAME:SEGMENT-NUMBER. Of course,
>> the
>> problem here is that "submodule" is sometimes at segment 1 of the
>> path
>> (under /trunk), but at segment 2 for /tags and /branches.
>>
>> The difference between /trunk and /tags and /branches could be
>> handled
>> with a separate [group] which matches specific paths using for_paths.
>
> Oh. This might be even clearer

i'm not so sure. I spent more time reading this email then the last
one you
sent.

> path_headers = module/branch/submodule/.../file
>
> [ where /.../ means "match the rest of the segments up to the last / ]
>
> or:
>
> for_paths = branches/
> path_headers = _/branch
>
> [ where _ means "match, but don't generate a header for this segment";
> the above also implies "ignore the rest of the path after those two
> segments" ]
>
> So in this form, you just specify the corresponding header name for
> each segment of the path. Use "_" for segments to ignore, and "/.../"
> to skip interim directories. For your setup:
>
> path_headers = module/branch/submodule/.../file
>
> For each segment name in path_headers, a corresponding header is
> generated in the mail: X-$name. It might be safe to generate
> X-Mailer-$name

why X-mailer infront?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1041183
Received on 2009-01-21 14:46:51 CET

This is an archived mail posted to the Subversion Dev mailing list.