Re: svn commit: r35314 - in trunk/subversion: include include/private libsvn_auth_gnome_keyring libsvn_subr

On Wed, Jan 21, 2009 at 12:02, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
>...
>>>...
>>> +++ trunk/subversion/include/svn_auth.h Sun Jan 18 09:55:07 2009 (r35314)
>>>...
>>> @@ -945,24 +925,46 @@ svn_auth_get_keychain_ssl_client_cert_pw
>>> #endif /* DARWIN || DOXYGEN */
>>>
>>> #if (!defined(DARWIN) && !defined(WIN32)) || defined(DOXYGEN)
>>
>> I thought these crazy #if lines were supposed to be fixed?
>
> What is wrong with these lines?
> GNOME Keyring / KWallet providers aren't available on Mac OS / Windows.

And it might not be available on FreeBSD or my RHEL box or ...

Basing the decision on the OS is (IMO) very poor form. Shoot. I bet
you I could build the keyring stuff and run it on my MacOS box. Silly,
but possible, in case I wanted to run a bunch of GNOME applications.

I thought we had already changed one or more of these to something
like SVN_HAVE_GNOME_KEYRING_SUPPORT or somesuch.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1040880
Received on 2009-01-21 12:16:25 CET