[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] calling diff_summarize from SVN Perl bindings

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 20 Jan 2009 10:25:59 +0000

I have checked that the patch builds against current trunk, but I don't
understand SWIG so need someone else to review/test/commit it.

I have attached the latest version of the patch (with the POD fix, from
from Mon, 19 Jan 2009 21:08:59 +0800) as a diff against trunk_at_35343,
with the log message included (tweaked just a little).

Hyrum K. Wright wrote:
> Daniel Shahaf wrote:
> > Good point. @James: yes, please verify that the patch still applies and
> > to trunk works as intended. (I see that you have already fixed the tabs
> > issue.)
> >
> > Also, for next time, it's better to send patches using a text/* MIME type,
> > rather than 'application/octet-stream' as you did. (Sometimes, naming the
> > patch file with a '.txt' extension causes 'text/plain' to be used.)
>
> One more suggestion: include a log message. From HACKING: "Please include a log
> message with your patch. A good log message helps potential reviewers understand
> the changes in your patch, and increases the likelihood that it will be
> applied." You can find the log message guidelines here:
> http://subversion.tigris.org/hacking.html#log-messages

James did include a log message initially, he just forgot to re-send it
with the updated patches. It looks the updates will not require a change
to the log message.

> -Hyrum
>
> PS - Please don't feel like we're trying to emphasis process over substance.
> That's not the point! We've just discovered over the years that these processes
> help improve the quality of the software, and that encouraging new contributors
> to follow them early on creates better maintainers in the future. Thanks for
> the patches!

Yes, indeed. Sorry for the large number of emails about this. Thanks for
the patches!

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1037583

Received on 2009-01-20 11:26:23 CET

This is an archived mail posted to the Subversion Dev mailing list.