[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] calling diff_summarize from SVN Perl bindings

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 19 Jan 2009 19:23:44 +0200 (Jerusalem Standard Time)

Julian Foad wrote on Mon, 19 Jan 2009 at 09:03 -0000:
> Daniel Shahaf wrote:
> > Please wait a little bit more than just one weekend before deciding your
> > patch was ignored. :-)
> >
> >
> > Also, a couple of stylistic bugs while I'm here:
> >
> > * Please write patches against trunk. (And if not against trunk, do
> > indicate that at the time you post them.)
> >
> > * Use spaces, not tabs.
> >
> >
> > Thanks for the patch,
>
> Daniel, it may not be clear to James whether you require him to fix
> those things before his patch will be accepted.
>

Good point. @James: yes, please verify that the patch still applies and
to trunk works as intended. (I see that you have already fixed the tabs
issue.)

Also, for next time, it's better to send patches using a text/* MIME type,
rather than 'application/octet-stream' as you did. (Sometimes, naming the
patch file with a '.txt' extension causes 'text/plain' to be used.)

Thanks for pointing it out, Julian. <excuse id="179525"/>

Daniel

> - Julian
>
>
> > Daniel
> >
> > James Fang wrote on Sun, 18 Jan 2009 at 20:46 +0800:
> > > hi, sorry to interrupt.
> > > can you apply this patch so that it may come up in the next subversion
> > > release?
> > > because one of our system rely on the diff_summarize from Perl. we do not
> > > want to
> > > apply the patch ourself and build our own RPM packages when there are new
> > > SVN
> > > release.
> > > this patch is against the 1.5.4 release, and i have tested it on CentOS
> > > 5.2.
> > >
> [...]
>
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1035131
Received on 2009-01-19 20:03:32 CET

This is an archived mail posted to the Subversion Dev mailing list.