[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] calling diff_summarize from SVN Perl bindings

From: James Fang <june.fang_at_gmail.com>
Date: Mon, 19 Jan 2009 21:01:41 +0800

Hi, Yes, i am also curious whether the patch is accepted before i change
those styles.
Thank you, Julian.
    I am sorry that i forget it's weekends, but i was pushed by my manager
since maintaining
a home-grown RPM would cause us much troubles, so we want to make sure about
this
ASAP.
    This patch is against 1.5.4 release, and i have replaced tab with
spaces. Since the
modified source is in our corporate intra-net that's isolated from the
internet, so i hope you
can apply it to the 1.5.4 and then merge to trunk.
    Sorry for the inconvenience, thanks in advance.

On Mon, Jan 19, 2009 at 5:03 PM, Julian Foad <julianfoad_at_btopenworld.com>wrote:

> Daniel Shahaf wrote:
> > Please wait a little bit more than just one weekend before deciding your
> > patch was ignored. :-)
> >
> >
> > Also, a couple of stylistic bugs while I'm here:
> >
> > * Please write patches against trunk. (And if not against trunk, do
> > indicate that at the time you post them.)
> >
> > * Use spaces, not tabs.
> >
> >
> > Thanks for the patch,
>
> Daniel, it may not be clear to James whether you require him to fix
> those things before his patch will be accepted.
>
> - Julian
>
>
> > Daniel
> >
> > James Fang wrote on Sun, 18 Jan 2009 at 20:46 +0800:
> > > hi, sorry to interrupt.
> > > can you apply this patch so that it may come up in the next
> subversion
> > > release?
> > > because one of our system rely on the diff_summarize from Perl. we do
> not
> > > want to
> > > apply the patch ourself and build our own RPM packages when there are
> new
> > > SVN
> > > release.
> > > this patch is against the 1.5.4 release, and i have tested it on
> CentOS
> > > 5.2.
> > >
> [...]
>
>
>

-- 
James Fang

Received on 2009-01-19 14:52:20 CET

This is an archived mail posted to the Subversion Dev mailing list.