[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r35309 - in trunk/subversion: include libsvn_fs libsvn_fs_base/bdb libsvn_fs_fs

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Mon, 19 Jan 2009 11:42:05 +0100

> -----Original Message-----
> From: dglasser_at_gmail.com [mailto:dglasser_at_gmail.com] On Behalf Of David
> Glasser
> Sent: maandag 19 januari 2009 4:33
> To: dev_at_subversion.tigris.org
> Cc: svn_at_subversion.tigris.org
> Subject: Re: svn commit: r35309 - in trunk/subversion: include
> libsvn_fs libsvn_fs_base/bdb libsvn_fs_fs
>
> On Sat, Jan 17, 2009 at 8:42 PM, Bert Huijben <rhuijben_at_sharpsvn.net>
> wrote:
> > Author: rhuijben
> > Date: Sat Jan 17 17:42:15 2009
> > New Revision: 35309
> >
> > Log:
> > Following up on r35253, make the svn_fs_path_change2_t type future
> extensible
> > by adding a constructor function.
> >
> > * subversion/include/svn_fs.h
> > (svn_fs_path_change2_t): Document as future extensible.
> > (svn_fs_path_change2_create): New function.
> > * subversion/libsvn_fs/util.c: Add new file
> > (svn_fs_path_change2_create): Implement constructor.
> > * subversion/libsvn_fs_base/bdb/changes-table.c
> > (fold_change): Use svn_fs_path_change2_create to create
> > svn_fs_path_change2_t.
> > * subversion/libsvn_fs_fs/fs_fs.c
> > (svn_fs_fs__add_change): Use svn_fs_path_change2_create to create
> > svn_fs_path_change2_t.
> >
> > Added:
> > trunk/subversion/libsvn_fs/util.c (contents, props changed)
> > Modified:
> > trunk/subversion/include/svn_fs.h
> > trunk/subversion/libsvn_fs_base/bdb/changes-table.c
> > trunk/subversion/libsvn_fs_fs/fs_fs.c
> >
> > Modified: trunk/subversion/include/svn_fs.h
> > URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_fs.h?path
> rev=35309&r1=35308&r2=35309
> >
> =======================================================================
> =======
> > --- trunk/subversion/include/svn_fs.h Sat Jan 17 17:00:25 2009
> (r35308)
> > +++ trunk/subversion/include/svn_fs.h Sat Jan 17 17:42:15 2009
> (r35309)
> > @@ -1047,6 +1047,10 @@ typedef enum
> >
> > /** Change descriptor.
> > *
> > + * @note Fields may be added to the end of this structure in future
> > + * versions. Therefore, to preserve binary compatibility, users
> > + * should not directly allocate structures of this type.
> > + *
> > * @since New in 1.6. */
> > typedef struct svn_fs_path_change2_t
> > {
> > @@ -1072,6 +1076,8 @@ typedef struct svn_fs_path_change2_t
> > svn_revnum_t copyfrom_rev;
> > const char *copyfrom_path;
> >
> > + /* NOTE! Please update svn_fs_path_change2_dup() when adding new
> > + fields here. */
>
> Does this exist?

No, it doesn't (Comment was fixed in r35310). It should exist but it is not
possible to duplicate the node_revision_id at this layer. (It's
implementation is different per fs implementation)

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1034241
Received on 2009-01-19 12:28:43 CET

This is an archived mail posted to the Subversion Dev mailing list.